Re: [PATCH v2] mfd: stmpe: Revert "Constify static struct resource"

From: Lee Jones
Date: Tue Mar 09 2021 - 13:18:03 EST


On Fri, 05 Mar 2021, Rikard Falkeborn wrote:

> In stmpe_devices_init(), the start and end field of these structs are
> modified, so they can not be const. Add a comment to those structs that
> lacked it to reduce the risk that this happens again.
>
> This reverts commit 8d7b3a6dac4eae22c58b0853696cbd256966741b.
>
> Fixes: 8d7b3a6dac4e ("mfd: stmpe: Constify static struct resource")
> Reported-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>
> ---
> Changes
> V1-V2: Add comments to the structs that they are dynamically modified
> Rewrite commit message.
>
> V1: https://lore.kernel.org/lkml/20210302234710.74455-1-rikard.falkeborn@xxxxxxxxx/
>
> drivers/mfd/stmpe.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog