Re: [PATCH v5] printk: Userspace format enumeration support

From: Chris Down
Date: Wed Mar 10 2021 - 07:18:46 EST


Hey Petr,

Chris Down writes:
$ head -1 vmlinux; shuf -n 5 vmlinux
# <level[,flags]> filename:line function "format"
<5> block/blk-settings.c:661 disk_stack_limits "%s: Warning: Device %s is misaligned\n"
<4> kernel/trace/trace.c:8296 trace_create_file "Could not create tracefs '%s' entry\n"
<6> arch/x86/kernel/hpet.c:144 _hpet_print_config "hpet: %s(%d):\n"
<6> init/do_mounts.c:605 prepare_namespace "Waiting for root device %s...\n"
<6> drivers/acpi/osl.c:1410 acpi_no_auto_serialize_setup "ACPI: auto-serialization disabled\n"

Regardless of any of the internals, how does this format look to you? I ask because the sooner we agree on the format, the sooner I can provide an interim version of this patch to internal customers, even if the eventual implementation changes a little :-)

Thanks,

Chris