Re: [PATCH] docs: don't include Documentation/Kconfig twice

[Randy Dunlap]

On 3/7/21 6:00 AM, Sergei Trofimovich wrote:
> Before the change there were two inclusions of Documentation/Kconfig:
>     lib/Kconfig.debug:source "Documentation/Kconfig"
>     Kconfig: source "Documentation/Kconfig"
> 
> Kconfig also included 'source "lib/Kconfig.debug"'.
> 
> Noticed as two 'make menuconfig' entries in both top level menu
> and in 'Kernel hacking' menu. The patch keeps entries only in
> 'Kernel hacking'.
> 
> CC: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
> CC: Jonathan Corbet <corbet@xxxxxxx>
> Signed-off-by: Sergei Trofimovich <slyfox@xxxxxxxxxx>

Hi,
OK, it shouldn't be there in 2 places.

The current usage is good under Kernel Hacking (development),
but I can easily foresee cases where we would want user-selectable
Documentation/Kconfig options, so IMO it would be better to be
more independent (i.e., not in lib/Kconfig.debug).

Anyway, for either way that it's fixed:

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>


> ---
>  Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Kconfig b/Kconfig
> index 745bc773f567..97ed6389c921 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -28,5 +28,3 @@ source "crypto/Kconfig"
>  source "lib/Kconfig"
>  
>  source "lib/Kconfig.debug"
> -
> -source "Documentation/Kconfig"
> 

thanks.
-- 
~Randy