Re: [PATCH v5 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

[Srinivasa Rao Mandadapu]

Hi Doug,

Thanks for your time and inputs!!!

On 3/13/2021 2:58 AM, Doug Anderson wrote:
> Hi,
>
> On Fri, Mar 12, 2021 at 8:06 AM Srinivasa Rao Mandadapu
> <srivasam@xxxxxxxxxxxxxx> wrote:
> > +               dai-link@0 {
> > +                       link-name = "MultiMedia0";
> > +                       reg = <MI2S_PRIMARY>;
> > +                       cpu {
> > +                               sound-dai = <&lpass_cpu MI2S_PRIMARY>;
> > +                       };
> > +
> > +                       multimedia0_codec: codec {
> > +                               sound-dai = <&alc5682 MI2S_PRIMARY>;
> Please change "MI2S_PRIMARY" to "0". "MI2S_PRIMARY" is a numbering
> system for "lpass_cpu" not for "alc5682". I'm not aware of symbolic
> names for the alc5682's DAIs.
>
>  From digging through the code and testing, it appears that for alc5682:
> 0 - aif1
> 1 - aif2
>
> Thus you could be a little more documenting by doing:
>
> sound-dai = <&alc5682 0 /*aif1*/>;
>
> -Doug
Okay, I will change accordingly.

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.