Re: [PATCH 06/23] ASoC: cx2070x: remove duplicate else branch

From: Takashi Iwai
Date: Sun Mar 14 2021 - 04:33:19 EST


On Fri, 12 Mar 2021 19:22:29 +0100,
Pierre-Louis Bossart wrote:
>
> cppcheck warning:
>
> sound/soc/codecs/cx2072x.c:1436:10: style:inconclusive: Found
> duplicate branches for 'if' and 'else'. [duplicateBranch]
> } else if (type & 0x4) {
> ^
> sound/soc/codecs/cx2072x.c:1439:5: note: Found duplicate branches for
> 'if' and 'else'.
> } else {
> ^
> sound/soc/codecs/cx2072x.c:1436:10: note: Found duplicate branches for
> 'if' and 'else'.
> } else if (type & 0x4) {
> ^
>
> The last two branches do the same thing and can be collapsed together.
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi