Re: [PATCH] vmscan: retry without cache trim mode if nothing scanned

From: Tejun Heo
Date: Sun Mar 14 2021 - 18:51:39 EST


Hello,

On Sun, Mar 14, 2021 at 01:58:33PM -0700, Shakeel Butt wrote:
> > If my understanding were correct, what Tejun suggested is to add a fast
> > read interface to rstat to be used in hot path. And its accuracy is
> > similar as that of traditional per-CPU counter. But if we can regularly
> > update the lruvec rstat with something like vmstat_update(), that should
> > be OK for the issue described in this patch.
> >
>
> This is also my understanding. Tejun, please correct us if we misunderstood you.

Yeah, that was what I had on mind. Instead of always flushing on read, have
a variant where flushing is explicit and trigger that periodically (or
whichever way appropriate).

Thanks.

--
tejun