Re: [PATCH v4 3/4] clk: rockchip: support more core div setting

From: kernel test robot
Date: Mon Mar 15 2021 - 04:35:10 EST


Hi Elaine,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rockchip/for-next]
[also build test WARNING on v5.12-rc3 next-20210315]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Elaine-Zhang/clk-rockchip-add-clock-controller-for-rk3568/20210315-144202
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/081fc0189f5d4408e7c7425f4385392b0fd97d9f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Elaine-Zhang/clk-rockchip-add-clock-controller-for-rk3568/20210315-144202
git checkout 081fc0189f5d4408e7c7425f4385392b0fd97d9f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/clk/rockchip/clk-rk3188.c:187:67: warning: missing braces around initializer [-Wmissing-braces]
187 | static const struct rockchip_cpuclk_reg_data rk3188_cpuclk_data = {
| ^


vim +187 drivers/clk/rockchip/clk-rk3188.c

0e5bdb3f9fa5c2 Heiko Stuebner 2014-09-05 186
0e5bdb3f9fa5c2 Heiko Stuebner 2014-09-05 @187 static const struct rockchip_cpuclk_reg_data rk3188_cpuclk_data = {
0e5bdb3f9fa5c2 Heiko Stuebner 2014-09-05 188 .core_reg = RK2928_CLKSEL_CON(0),
0e5bdb3f9fa5c2 Heiko Stuebner 2014-09-05 189 .div_core_shift = 9,
0e5bdb3f9fa5c2 Heiko Stuebner 2014-09-05 190 .div_core_mask = 0x1f,
268aebaa241015 Xing Zheng 2016-03-09 191 .mux_core_alt = 1,
268aebaa241015 Xing Zheng 2016-03-09 192 .mux_core_main = 0,
0e5bdb3f9fa5c2 Heiko Stuebner 2014-09-05 193 .mux_core_shift = 8,
268aebaa241015 Xing Zheng 2016-03-09 194 .mux_core_mask = 0x1,
0e5bdb3f9fa5c2 Heiko Stuebner 2014-09-05 195 };
0e5bdb3f9fa5c2 Heiko Stuebner 2014-09-05 196

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip