Re: [PATCH] smp: kernel/panic.c - silence warnings

From: heying (H)
Date: Tue Mar 16 2021 - 02:37:06 EST

Thanks for your reply.

在 2021/3/16 13:15, Randy Dunlap 写道:
On 3/15/21 9:08 PM, He Ying wrote:
We found these warnings in kernel/panic.c by using sparse tool:
warning: symbol 'panic_smp_self_stop' was not declared.
warning: symbol 'nmi_panic_self_stop' was not declared.
warning: symbol 'crash_smp_send_stop' was not declared.

To avoid them, add declarations for these three functions in

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: He Ying <heying24@xxxxxxxxxx>
include/linux/smp.h | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/include/linux/smp.h b/include/linux/smp.h
index 70c6f6284dcf..861a253cc179 100644
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -50,6 +50,14 @@ extern unsigned int total_cpus;
int smp_call_function_single(int cpuid, smp_call_func_t func, void *info,
int wait);
+ * Cpus stopping functions in panic. All have default weak definations.
Sorry for my typo.

+ * Architecure dependent code may override them.
Is that necessary?

+ */
+void panic_smp_self_stop(void);
+void nmi_panic_self_stop(struct pt_regs *regs);
+void crash_smp_send_stop(void);
* Call a function on all processors