Re: [PATCH v8] i2c: virtio: add a virtio i2c frontend driver

[Viresh Kumar]

On 16-03-21, 18:35, Jie Deng wrote:
> diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c
> +struct virtio_i2c {
> +	struct virtio_device *vdev;
> +	struct completion completion;
> +	struct i2c_adapter *adap;
> +	struct mutex lock;
> +	struct virtqueue *vq;
> +};

> +static struct i2c_adapter virtio_adapter = {
> +	.owner = THIS_MODULE,
> +	.name = "Virtio I2C Adapter",
> +	.class = I2C_CLASS_DEPRECATED,
> +	.algo = &virtio_algorithm,
> +};

And FWIW, I still have my concerns about mutex-lock and
I2C_CLASS_DEPRECATED, but yeah we need Wolfram to confirm on them.

LGTM otherwise.

-- 
viresh