Re: [PATCH] drm/omap: dsi: fix unsigned expression compared with zero

From: Tomi Valkeinen
Date: Tue Mar 16 2021 - 10:04:41 EST


On 14/03/2021 04:15, Laurent Pinchart wrote:
Hi Junlin,

Thank you for the patch.

On Fri, Mar 12, 2021 at 03:14:45PM +0800, angkery wrote:
From: Junlin Yang <yangjunlin@xxxxxxxxxx>

r is "u32" always >= 0,mipi_dsi_create_packet may return little than zero.
so r < 0 condition is never accessible.

Fixes coccicheck warnings:
./drivers/gpu/drm/omapdrm/dss/dsi.c:2155:5-6:
WARNING: Unsigned expression compared with zero: r < 0

Signed-off-by: Junlin Yang <yangjunlin@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Tomi, will you take this in your tree ?

Thanks. Yes, I'll pick this up.

Tomi