Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

[Tianling Shen]

Hi Geert,

On 2021-03-16 02:23 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> Personally, I'm not so fond of the <foo>-%u node names, and prefer
> <foo>-<function>.  With the former, it's way too easy to have a silent
> override in your .dts(i) stack.
> Cfr. commit 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak:
> Fix backlight regulator name")

How about using `lan-led`, `sys-led` and `wan-led` here?

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Thanks,
Tianling.