Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver

From: Mihai Carabas
Date: Tue Mar 16 2021 - 13:10:03 EST

+static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
+static unsigned int events;
+static ssize_t capability_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ return sysfs_emit(buf, "%x\n", capability);
A global capability for all devices? No, this needs to be a per-device
attttribute as you are showing it to userspace as such.

We can only have a pvpanic-pci device. This is necessary in that case?

+static struct attribute *pvpanic_pci_dev_attrs[] = {
+ &dev_attr_capability.attr,
+ &dev_attr_events.attr,
You did not document these new sysfs files in Documentation/ABI/ so it's
hard to judge what they do. Please do so next version.

This appeared after 5.12 rebase on pvpanic-mmio. I did this changes to pvpanic-pci to be on the same page as pvpanic-mmio which is described here: Documentation/ABI/testing/sysfs-bus-pci-devices-pvpanic.

Thank you,