Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

From: Pratyush Yadav
Date: Tue Mar 16 2021 - 14:10:17 EST


On 16/03/21 06:45PM, Michael Walle wrote:
> Am 2021-03-15 19:30, schrieb Pratyush Yadav:
>
> ..
> > > +patternProperties:
> > > + "@[0-9a-f]+":
>
> Shouldn't this be "^.*@[0-9a-f]+$"?

The pattern has to match _anywhere_ in the string so both should match
the flash node. Your pattern is more "strict" or "precise". See the note
at [0].

[0] https://json-schema.org/understanding-json-schema/reference/string.html#regular-expressions

>
> > > + type: object
> > > +
> > > + properties:
> > > + fsl,spi-cs-sck-delay:
> > > + description:
> > > + Delay in nanoseconds between activating chip select and
> > > the start of
> > > + clock signal, at the start of a transfer.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > +
> > > + fsl,spi-sck-cs-delay:
> > > + description:
> > > + Delay in nanoseconds between stopping the clock signal and
> > > + deactivating chip select, at the end of a transfer.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > +
> ..
>
> -michael

--
Regards,
Pratyush Yadav
Texas Instruments Inc.