Re: [net PATCH 3/9] octeontx2-af: Do not allocate memory for devlink private
From: Jakub Kicinski
Date: Tue Mar 16 2021 - 16:28:13 EST
On Tue, 16 Mar 2021 23:33:40 +0530 sundeep subbaraya wrote:
> On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> > On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote:
> > > From: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>
> > >
> > > Memory for driver private structure rvu_devlink is
> > > also allocated during devlink_alloc. Hence use
> > > the allocated memory by devlink_alloc and access it
> > > by devlink_priv call.
> > >
> > > Fixes: fae06da4("octeontx2-af: Add devlink suppoort to af driver")
> > > Signed-off-by: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>
> > > Signed-off-by: Hariprasad Kelam <hkelam@xxxxxxxxxxx>
> > > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>
> > Does it fix any bug? Looks like a coding improvement.
> Without this we cannot fetch our private struct 'rvu_devlink' from any
> of the functions in devlink_ops which may get added in future.
"which may get added in future" does not sound like it's fixing
an existing problem to me :(
If you have particular case where the existing setup is problematic
please describe it in more detail, or mention what other fix depends
on this patch. Otherwise sending this one patch for net-next would
be better IMHO.