Re: [PATCH] perf stat: Align CSV output for summary mode

[Jin, Yao]

On 3/17/2021 5:55 AM, Jiri Olsa wrote:
> On Tue, Mar 16, 2021 at 01:02:20PM -0700, Andi Kleen wrote:
> > On Tue, Mar 16, 2021 at 04:05:13PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Tue, Mar 16, 2021 at 09:34:21AM -0700, Andi Kleen escreveu:
> > > > > looks ok, but maybe make the option more related to CVS, like:
> > > > >
> > > > >    --x-summary, --cvs-summary  ...?
> > > >
> > > > Actually I don't think it should be a new option. I doubt
> > > > anyone could parse the previous mess. So just make it default
> > > > with -x
> > >
> > > In these cases I always fear that people are already parsing that mess
> > > by considering the summary lines to be the ones not starting with
> > > spaces, and now we go on and change it to be "better" by prefixing it
> > > with "summary" and... break existing scripts.
> >
> > I think it was just one version or so?
> >
> > FWIW perf has broken CSV output several times, I added workarounds
> > to toplev every time. Having a broken version for a short time
> > shouldn't be too bad.
> >
> > I actually had a workaround for this one, but it can parse either way.
> >
> > > Can we do this with a new option?
> > >
> > > I.e. like --cvs-summary?
> >
> > If you do it I would add an option for the old broken format
> > --i-want-broken-csv. But not  require the option forever
> > just to get sane output.
>
> I like that.. also we'll find out how many people are actually parsing that ;-)
>
> jirka

Is it serious or just a joke? :)

Thanks
Jin Yao

> > Or maybe only a perf config option.
> >
> > -Andi