[PATCH v2] sched: replace if (cond) BUG() with WARN_ON()

From: Jiapeng Chong
Date: Wed Mar 17 2021 - 03:34:34 EST


Fix the following coccicheck warnings:

./arch/powerpc/platforms/cell/spufs/sched.c:908:2-5: WARNING: Use BUG_ON
instead of if condition followed by BUG.

Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
---
Changes in v2:
- replace BUG with WARN_ON.

arch/powerpc/platforms/cell/spufs/sched.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/cell/spufs/sched.c b/arch/powerpc/platforms/cell/spufs/sched.c
index 3692064..1031448 100644
--- a/arch/powerpc/platforms/cell/spufs/sched.c
+++ b/arch/powerpc/platforms/cell/spufs/sched.c
@@ -904,8 +904,7 @@ static noinline void spusched_tick(struct spu_context *ctx)
struct spu_context *new = NULL;
struct spu *spu = NULL;

- if (spu_acquire(ctx))
- BUG(); /* a kernel thread never has signals pending */
+ WARN_ON(spu_acquire(ctx)); /* a kernel thread never has signals pending */

if (ctx->state != SPU_STATE_RUNNABLE)
goto out;
--
1.8.3.1