Re: [PATCH v6 1/2] RISC-V: Don't print SBI version for all detected extensions

From: Anup Patel
Date: Wed Mar 17 2021 - 04:32:21 EST


On Wed, Mar 17, 2021 at 10:38 AM Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote:
>
> On Mon, 15 Mar 2021 04:04:59 PDT (-0700), Anup Patel wrote:
> > The sbi_init() already prints SBI version before detecting
> > various SBI extensions so we don't need to print SBI version
> > for all detected SBI extensions.
> >
> > Signed-off-by: Anup Patel <anup.patel@xxxxxxx>
> > ---
> > arch/riscv/kernel/sbi.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c
> > index f4a7db3d309e..c0dcebdd30ec 100644
> > --- a/arch/riscv/kernel/sbi.c
> > +++ b/arch/riscv/kernel/sbi.c
> > @@ -577,19 +577,19 @@ void __init sbi_init(void)
> > sbi_get_firmware_id(), sbi_get_firmware_version());
> > if (sbi_probe_extension(SBI_EXT_TIME) > 0) {
> > __sbi_set_timer = __sbi_set_timer_v02;
> > - pr_info("SBI v0.2 TIME extension detected\n");
> > + pr_info("SBI TIME extension detected\n");
> > } else {
> > __sbi_set_timer = __sbi_set_timer_v01;
> > }
> > if (sbi_probe_extension(SBI_EXT_IPI) > 0) {
> > __sbi_send_ipi = __sbi_send_ipi_v02;
> > - pr_info("SBI v0.2 IPI extension detected\n");
> > + pr_info("SBI IPI extension detected\n");
> > } else {
> > __sbi_send_ipi = __sbi_send_ipi_v01;
> > }
> > if (sbi_probe_extension(SBI_EXT_RFENCE) > 0) {
> > __sbi_rfence = __sbi_rfence_v02;
> > - pr_info("SBI v0.2 RFENCE extension detected\n");
> > + pr_info("SBI RFENCE extension detected\n");
> > } else {
> > __sbi_rfence = __sbi_rfence_v01;
> > }
>
> Thanks. I'm just putting this one on for-next so you don't have to carry
> around the diff.

Thanks Palmer.