RE: [PATCH v5 03/10] scsi: ufshpb: Add region's reads counter

From: Avri Altman
Date: Wed Mar 17 2021 - 05:20:54 EST


> >> > @@ -1079,6 +1113,14 @@ static void __ufshpb_evict_region(struct
> >> > ufshpb_lu *hpb,
> >> >
> >> > ufshpb_cleanup_lru_info(lru_info, rgn);
> >> >
> >> > + if (hpb->is_hcm) {
> >> > + unsigned long flags;
> >> > +
> >> > + spin_lock_irqsave(&rgn->rgn_lock, flags);
> >> > + rgn->reads = 0;
> >> > + spin_unlock_irqrestore(&rgn->rgn_lock, flags);
> >> > + }
> >> > +
While at it, Following your comments concerning the unmap request,
Better move this as well outside of __ufshpb_evict_region while rgn_state_lock is not held.

Thanks,
Avri