Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

From: Andy Shevchenko
Date: Wed Mar 17 2021 - 05:41:21 EST


On Wed, Mar 17, 2021 at 11:36 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Mar 17, 2021 at 10:21 AM Menglong Dong <menglong8.dong@xxxxxxxxx> wrote:

...

> It maybe fixed by swapping positions of the arguments, i.e. ~(FOO |
> BAR) & flags.

...and type casting will be needed anyway here...

I was thinking about this case

drivers/i2c/busses/i2c-designware-common.c:420:
dev->sda_hold_time & ~(u32)DW_IC_SDA_HOLD_RX_MASK
,

but sda_hold_time there is unsigned.

--
With Best Regards,
Andy Shevchenko