Re: [PATCH] sched: swait: use wake_up_process() instead of wake_up_state()

From: Ingo Molnar
Date: Wed Mar 17 2021 - 05:47:18 EST



* Mike Galbraith <efault@xxxxxx> wrote:

> On Tue, 2021-03-16 at 19:20 +0800, Wang Qing wrote:
> > Why not just use wake_up_process().
>
> IMO this is not an improvement. There are other places where explicit
> TASK_NORMAL is used as well, and they're all perfectly clear as is.

Arguably those could all be converted to wake_up_process() as well.
It's a very small kernel code size optimization. There's about 3 such
places, could be converted in a single patch.

Thanks,

Ingo