Re: [PATCH 1/3] arm64: dts: qcom: sm8350: Remove second reg from pdc

From: Maulik Shah
Date: Wed Mar 17 2021 - 05:49:26 EST


Hi Marc,

On 3/17/2021 2:47 PM, Marc Zyngier wrote:
On Wed, 17 Mar 2021 05:29:54 +0000,
Maulik Shah <mkshah@xxxxxxxxxxxxxx> wrote:
PDC interrupt controller driver do not use second reg. Remove it.
This is a DT file, not a driver. What the driver does is irrelevant.

The real question is: what does this range do?

Thanks,

M.

This is to set interrupt type in SPI config for which there was a change [1] but has not gone in for upstream PDC driver.

The second reg is not used in upstream PDC driver, probably when posting downstream DT changes for sm8350/sm8250 it was carried in device node as is.

As its not mentioned in bindigs as well, dtbs_check reports it as additional reg when converted to yaml.

[1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1568411962-1022-8-git-send-email-ilina@xxxxxxxxxxxxxx/

Thanks,
Maulik

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation