Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards

From: Heiko Thiery
Date: Wed Mar 17 2021 - 07:53:32 EST


Hi Shawn,

Am Mi., 17. März 2021 um 09:02 Uhr schrieb Shawn Guo <shawnguo@xxxxxxxxxx>:
>
> On Thu, Mar 11, 2021 at 08:27:47PM +0100, Heiko Thiery wrote:
> > Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk,
> > imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra.
> >
> > Signed-off-by: Heiko Thiery <heiko.thiery@xxxxxxxxx>
> > ---
> > v2:
> > - slightly modified the commit message (Fabio Estevam)
> >
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 1f673b00c5f5..522bae6a8f21 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y
> > CONFIG_PCI_HOST_THUNDER_ECAM=y
> > CONFIG_PCIE_ROCKCHIP_HOST=m
> > CONFIG_PCIE_BRCMSTB=m
> > +CONFIG_PCI_IMX6=y
>
> Do we really want it to be built-in? If so, it would be nice to have some
> comments about that in commit log.

Why would you not want it? I see other SOC PCI controllers are also
enabled. I would like to have it because we have an Intel e1000 on our
pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we
would have the PCI support with the default defconfig. On the NXP
imx8mq EVK a m.2 is connected to the PCI interface.

Is this the kind of comments you want?

> Shawn
>
> > CONFIG_PCI_LAYERSCAPE=y
> > CONFIG_PCIE_LAYERSCAPE_GEN4=y
> > CONFIG_PCI_HISI=y
> > --
> > 2.30.0
> >

BR
--
Heiko
--
Heiko