Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards

[Fabio Estevam]

Hi Heiko,

On Wed, Mar 17, 2021 at 8:52 AM Heiko Thiery <heiko.thiery@xxxxxxxxx> wrote:

> > Do we really want it to be built-in?  If so, it would be nice to have some
> > comments about that in commit log.
>
> Why would you not want it? I see other SOC PCI controllers are also
> enabled. I would like to have it because we have an Intel e1000 on our
> pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we
> would have the PCI support with the default defconfig. On the NXP
> imx8mq EVK a m.2 is connected to the PCI interface.
>
> Is this the kind of comments you want?

You have selected the driver to be built-in:
CONFIG_PCI_IMX6=y

Shawn's question is why it needs to be built-in instead of a kernel module:

CONFIG_PCI_IMX6=m

On arch/arm64/configs/defconfig the preference is to select the
options as modules, whenever possible.

If it can't be a module and needs to be built-in, then please provide
a justification in the commit log.

Hope this can clarify.