Re: [PATCH v5 33/36] KVM: arm64: Wrap the host with a stage 2

From: Mate Toth-Pal
Date: Wed Mar 17 2021 - 11:58:51 EST


On 2021-03-17 10:02, Quentin Perret wrote:
On Wednesday 17 Mar 2021 at 09:41:09 (+0100), Mate Toth-Pal wrote:
On 2021-03-16 18:46, Quentin Perret wrote:
On Tuesday 16 Mar 2021 at 16:16:18 (+0100), Mate Toth-Pal wrote:
On 2021-03-16 15:29, Quentin Perret wrote:
On Tuesday 16 Mar 2021 at 12:53:53 (+0000), Quentin Perret wrote:
On Tuesday 16 Mar 2021 at 13:28:42 (+0100), Mate Toth-Pal wrote:
Changing the value of MT_S2_FWB_NORMAL to 7 would change this behavior, and
the resulting memory type would be device.

Sounds like the correct fix here -- see below.

Just to clarify this, I meant this should be the configuration for the
host stage-2. We'll want to keep the existing behaviour for guests I
believe.

I Agree.

OK, so the below seems to boot on my non-FWB-capable hardware and should
fix the issue. Could you by any chance give it a spin?


Sure, I can give it a go. I was trying to apply the patch on top of https://android-kvm.googlesource.com/linux/+/refs/heads/qperret/host-stage2-v5
but it seems that your base is significantly different. Can you give some
hints what should I use as base?

Oh interesting, it _should_ apply on v5. I just pushed a branch with
everything applied if that helps:

https://android-kvm.googlesource.com/linux qperret/wip/fix-fwb-host-stage2

Thanks again!
Quentin


Sorry, it was my mistake. I must have messed up my source, because the patch should really have applied on the v5 patchset.

So I was able to boot the kernel from the branch qperret/wip/fix-fwb-host-stage2 on the machine I was testing, so the fix looks to be OK.

Thanks,
Mate