Re: [PATCH] misc/sgi-xp: use NULL instead of using plain integer as pointer

From: Steve Wahl
Date: Wed Mar 17 2021 - 12:35:43 EST


Reviewed-by: Steve Wahl <steve.wahl@xxxxxxx>

On Tue, Mar 16, 2021 at 04:57:21PM +0800, Yang Li wrote:
> This fixes the following sparse warnings:
> drivers/misc/sgi-xp/xpc_main.c:210:23: warning: Using plain integer as
> NULL pointer
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
> drivers/misc/sgi-xp/xpc_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c
> index 84610bb..b2c3c22 100644
> --- a/drivers/misc/sgi-xp/xpc_main.c
> +++ b/drivers/misc/sgi-xp/xpc_main.c
> @@ -207,7 +207,7 @@
> {
> xpc_arch_ops.heartbeat_init();
> timer_setup(&xpc_hb_timer, xpc_hb_beater, 0);
> - xpc_hb_beater(0);
> + xpc_hb_beater(NULL);
> }
>
> static void
> --
> 1.8.3.1
>

--
Steve Wahl, Hewlett Packard Enterprise