Re: [PATCH v2 4/5] mtd: spi-nor: Move Software Write Protection logic out of the core

From: Michael Walle
Date: Wed Mar 17 2021 - 13:51:27 EST

Am 2021-03-17 10:30, schrieb Tudor.Ambarus@xxxxxxxxxxxxx:
soft-wr-protect.c or software-write-protect.c ?

Having in mind that we have the SWP configs, I think I prefer swp.c.
But let's see what majority thinks, we'll do as majority prefers.
Michael, Pratyush?

It's just an internal name, thus as long as it remotely makes sense,
I'm fine. It's just a matter of taste, isn't it?

Sure, it's a matter of preference. What's yours?

if i have to choose, swp.c

But here's one technical reason that would bother me more: name
clashes between the core modules: core, sfdp, otp, swp and the
vendor names. It is very unlikely, but there is a non-zero chance ;)

We can move all manufacturers to a manufacturers/ folder. Each manufacturer
driver will have to #include "../core.h", about what I have some mixed

I don't think it makes sense as long as there is no clash; or until there
are many more core modules, so you can't keep them apart anymore.
It will just make it harder to follow the git history.