Re: [PATCH v2] smp: kernel/panic.c - silence warnings

[Christophe Leroy]

Le 18/03/2021 à 03:56, heying (H) a écrit :
> 在 2021/3/18 4:09, Ingo Molnar 写道:
> > * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> >
> > > Now, the C people figured that distinction was useless and allowed
> > > sloppiness. But I still think there's merrit to that. And as
> > > mentioned earlier, it is consistent with variable declarations.
> > Fully agreed, and my other point was that it's also consistent with
> > the other existing externs were used *in the same header file*
> > already.
> >
> > I.e. there's nothing more sloppy than mixing different styles within
> > the same header. Checkpatch needs to be fixed or ignored here.
>
> Thank you all for the reply!
>
> There are already mixing different styles within linux/smp.h. I mean 'extern' and
>
> non 'extern' func declarations both exist in this header. Since two of you three
>
> think that 'extern' is needed, I'll add it and resend my patch.

As you are pointing, there are already non 'extern' func protoypes in the file, the conversion has 
already started, so flagging new prototypes with 'extern' would be a step backwards.