Re: [PATCH v2] usb: cdns3: Optimize DMA request buffer allocation

From: Christoph Hellwig
Date: Thu Mar 18 2021 - 03:34:10 EST


On Wed, Mar 17, 2021 at 08:13:59PM +0100, Sanket Parmar wrote:
> dma_alloc_coherent() might fail on the platform with a small
> DMA region.
>
> To avoid such failure in cdns3_prepare_aligned_request_buf(),
> dma_alloc_coherent() is replaced with dma_alloc_noncoherent()
> to allocate aligned request buffer of dynamic length.
>
> Reported-by: Aswath Govindraju <a-govindraju@xxxxxx>
> Signed-off-by: Sanket Parmar <sparmar@xxxxxxxxxxx>

Looks good to me:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>