Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

From: Leon Romanovsky
Date: Thu Mar 18 2021 - 03:56:04 EST

On Wed, Mar 17, 2021 at 01:17:32PM -0700, Linus Torvalds wrote:
> On Wed, Mar 17, 2021 at 3:46 AM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> >
> > I'm sending this patch to you directly because it is much saner to
> > apply it in one place instead of multiple patches saga that will
> > span for at least two cycles if per-maintainer path will be taken.
> >
> > It applies cleanly on v5.12-rc2 and completely unharmful.
> You have an odd whitespace-only part in the patch inside the comment
> underneath the "remove RME,Hammerfall" case.

This is something that I missed, my VIM changed whitespaces in many old
files and I didn't pay attention when added that chunk.

> Also, your email seems to have swallowed spaces at the ends of lines.
> I can (and did) apply the patch with "--whitespace=fix", but that then
> causes git to fix some _other_ whitespace too, so the end result isn't
> quite the same. Oh well.
> Please check what's up with your email sending client that it seems to
> remove space at end of lines in patches.

This is strange, I'm sending patches with "git send-email" with pretty
standard settings:

28 [sendemail]
29 smtpserver = /usr/local/bin/
30 suppresscc = self
31 chainReplyTo = false
32 confirm = always
33 from = Leon Romanovsky <leon@xxxxxxxxxx>
34 envelopeSender = Leon Romanovsky <leon@xxxxxxxxxx>
35 signingkey = leon@xxxxxxxxxx
36 composeencoding = utf-8

Also, I'm using as a SMTP especially to make sure that
my mails are not mangled by our exchange server.

Are you sure that such change came from me and not from "--whitespace=fix"?


> Linus