Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call
From: Krzysztof Kozlowski
Date: Fri Mar 19 2021 - 06:00:25 EST
On 18/03/2021 21:42, Jens Axboe wrote:
> On 3/18/21 2:24 PM, Colin Ian King wrote:
>> On 18/03/2021 20:12, Jens Axboe wrote:
>>> On 3/18/21 9:16 AM, Colin King wrote:
>>>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>>> The 3rd argument to alloc_workqueue should be the max_active count,
>>>> however currently it is the lo->lo_number that is intended for the
>>>> loop%d number. Fix this by adding in the missing max_active count.
>>> Dan, please fold this (or something similar) in when you're redoing the
>> Appreciate this fix being picked up. Are we going to lose the SoB?
> If it's being redone, would be silly to have that error in there. Do
> we have a tag that's appropriate for this? I often wonder when I'm
> folding in a fix. Ala Fixes-by: or something like that.
Why it is being redone if it was put into next? And even then, several
other maintainers just apply a fix on top (I think Andrew Morton, Greg
KH, Mark Brown) to avoid rebasing, preserve the history and also give
credits to the fixer.
Anyway, if it is going to be squashed at least SoB would be nice (as Dan
will take Colin's code).