Re: [PATCH v10 0/3] Charge loop device i/o to issuing cgroup

From: Shakeel Butt
Date: Fri Mar 19 2021 - 12:21:19 EST


On Fri, Mar 19, 2021 at 8:51 AM Dan Schatzberg <schatzberg.dan@xxxxxxxxx> wrote:
>
> On Thu, Mar 18, 2021 at 05:56:28PM -0700, Shakeel Butt wrote:
> >
> > We need something similar for mem_cgroup_swapin_charge_page() as well.
> >
> > It is better to take this series in mm tree and Jens is ok with that [1].
> >
> > [1] https://lore.kernel.org/linux-next/4fea89a5-0e18-0791-18a8-4c5907b0d2c4@xxxxxxxxx/
>
> It sounds like there are no concerns about the loop-related work in
> the patch series. I'll rebase on the mm tree and resubmit.

One suggestion would be to make get_mem_cgroup_from_mm() more generic
(i.e. handle !mm && active_memcg() case) and avoid
get_mem_cgroup_from_current() as it might go away.