Re: [PATCH] net/rds: correct socket tunable error in rds_tcp_tune()

From: Matthew Wilcox
Date: Fri Mar 19 2021 - 12:49:49 EST


On Wed, Mar 17, 2021 at 08:52:04AM -0600, William Kucharski wrote:
> Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would
> instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched.
>
> Signed-off-by: William Kucharski <william.kucharski@xxxxxxxxxx>

Looks like a pretty clear copy-n-paste error. I think Coverity have
started looking for issues like this?

Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Also, maybe,

Fixes: c6a58ffed536 ("RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket")