Re: [PATCH 3/3] static_call: Fix static_call_update() sanity check

From: Steven Rostedt
Date: Fri Mar 19 2021 - 14:00:54 EST


On Fri, 19 Mar 2021 13:57:38 +0100
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> Jessica, can you explain how !MODULE_UNLOAD is supposed to work?
> Alternatives, jump_labels and static_call all can have relocations into
> __exit code. Not loading it at all would be BAD.

According to the description:

" Without this option you will not be able to unload any
modules (note that some modules may not be unloadable anyway), which
makes your kernel smaller, faster and simpler.
If unsure, say Y."

Seems there's no reason to load the "exit" portion, as that's what makes it
"smaller".

Would making __exit code the same as init code work? That is, load it just
like module init code is loaded, and free it when the init code is freed
(hopefully keeping the kernel still "smaller, faster and simpler").


-- Steve