Re: [RFC PATCH v3 2/3] regmap-irq: Add support for POLARITY_HI and POLARITY_LO config regs

From: Guru Das Srinagesh
Date: Fri Mar 19 2021 - 22:39:01 EST

On Wed, Mar 17, 2021 at 08:42:12PM +0000, Mark Brown wrote:
> On Mon, Mar 15, 2021 at 01:33:37PM -0700, Guru Das Srinagesh wrote:
> > Since I do need to write to two extra registers, I'll need two
> > register_base's and two buffers to hold their data. This can be
> > generalized to "extra config registers" in the framework as follows:
> >
> > - Add these two fields to `struct regmap_irq_chip`:
> >
> > unsigned int *extra_config_base; /* Points to array of extra regs */
> > int num_extra_config_regs; /* = ARRAY_SIZE(array above) */
> I'm having a hard time loving this but I'm also not able to think of any
> better ideas so sure. I'd change the name to virtual (or virt) rather
> than extra since that's what they are so it makes it a bit omre clear.

Thanks for accepting the first patch in this series. I will test out my
proposed changes and then send a new patchset sometime next week.

Thank you.

Guru Das.