Re: [PATCH v2 1/2] optee: fix tee out of memory failure seen during kexec reboot

From: Allen Pais
Date: Mon Mar 22 2021 - 04:00:29 EST

[ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed
[ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22

tee_shm_release() is not invoked on dma shm buffer.

Implement .shutdown() method to handle the release of the buffers

More info:

Signed-off-by: Allen Pais <apais@xxxxxxxxxxxxxxxxxxx>
drivers/tee/optee/core.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

This looks good to me. Do you have a practical way of testing this on
QEMU for instance?


I could not reproduce nor create a setup using QEMU, I could only
do it on a real h/w.

I have extensively tested the fix and I don't see any issues.

I did a few test runs too, seems OK.

Thank you very much.