Re: [PATCH 1/3] arm64: dts: qcom: sm8350: Remove second reg from pdc

From: Maulik Shah
Date: Mon Mar 22 2021 - 06:27:15 EST


On 3/17/2021 11:38 PM, Bjorn Andersson wrote:
On Wed 17 Mar 09:02 CDT 2021, Marc Zyngier wrote:

On Wed, 17 Mar 2021 09:48:09 +0000,
Maulik Shah <mkshah@xxxxxxxxxxxxxx> wrote:
Hi Marc,

On 3/17/2021 2:47 PM, Marc Zyngier wrote:
On Wed, 17 Mar 2021 05:29:54 +0000,
Maulik Shah <mkshah@xxxxxxxxxxxxxx> wrote:
PDC interrupt controller driver do not use second reg. Remove it.
This is a DT file, not a driver. What the driver does is irrelevant.

The real question is: what does this range do?


This is to set interrupt type in SPI config for which there was a
change [1] but has not gone in for upstream PDC driver.

The second reg is not used in upstream PDC driver, probably when
posting downstream DT changes for sm8350/sm8250 it was carried in
device node as is.

As its not mentioned in bindigs as well, dtbs_check reports it as
additional reg when converted to yaml.
Then I'd rather you provide accurate documentation in the binding
rather than changing the DT files. Other operating systems may use it,
and it isn't unlikely that Linux could use the feature at some point.

I agree. Maulik, please update the DT binding to document this region as
sure. updated in v2.

It also seems relevant to pursue getting [1] into the upstream Linux
kernel. Is this something that you use downstream Maulik?

Yes its used in downstream. We can pursue to get [1] in.



QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation