Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support

From: Lee Jones
Date: Mon Mar 22 2021 - 11:04:08 EST


On Sat, 20 Mar 2021, min.li.xe@xxxxxxxxxxx wrote:

> From: Min Li <min.li.xe@xxxxxxxxxxx>
>
> Add support for ClockMatrix(TM) and 82P33xxx families of timing
> and synchronization devices. The access interface can be either
> SPI or I2C. Currently, it will create 2 types of MFD devices,
> which are to be used by the corresponding rsmu character device
> driver and the PTP hardware clock driver, respectively.
>
> Signed-off-by: Min Li <min.li.xe@xxxxxxxxxxx>
> ---
> drivers/mfd/Kconfig | 27 ++
> drivers/mfd/Makefile | 2 +
> drivers/mfd/rsmu_i2c.c | 344 +++++++++++++++++
> drivers/mfd/rsmu_private.h | 32 ++
> drivers/mfd/rsmu_spi.c | 371 ++++++++++++++++++
> include/linux/mfd/idt82p33_reg.h | 102 +++++
> include/linux/mfd/idt8a340_reg.h | 817 +++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/rsmu.h | 42 ++
> 8 files changed, 1737 insertions(+)
> create mode 100644 drivers/mfd/rsmu_i2c.c
> create mode 100644 drivers/mfd/rsmu_private.h
> create mode 100644 drivers/mfd/rsmu_spi.c
> create mode 100644 include/linux/mfd/idt82p33_reg.h
> create mode 100644 include/linux/mfd/idt8a340_reg.h
> create mode 100644 include/linux/mfd/rsmu.h

I'm pretty confused. This has been sent ~6 times already. What is
the v1 of? Is this a different driver? If so, why does it have the
same $SUBJECT line?

If this is not actually v1. Please provide a change-log.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 49bb445..1202301 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1196,6 +1196,33 @@ config MFD_STW481X
> endmenu
> endif

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog