Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

From: Lee Jones
Date: Tue Mar 23 2021 - 04:40:30 EST


On Mon, 22 Mar 2021, Daniel Thompson wrote:

> On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote:
> > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP.
> >
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
>
> Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

Why are you Reviewing/Acking a patch that was applied on the 10th?

> > ---
> > drivers/video/backlight/qcom-wled.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
> > index 3bc7800eb0a9..497b9035a908 100644
> > --- a/drivers/video/backlight/qcom-wled.c
> > +++ b/drivers/video/backlight/qcom-wled.c
> > @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev)
> >
> > static const struct of_device_id wled_match_table[] = {
> > { .compatible = "qcom,pm8941-wled", .data = (void *)3 },
> > + { .compatible = "qcom,pmi8994-wled", .data = (void *)4 },
> > { .compatible = "qcom,pmi8998-wled", .data = (void *)4 },
> > { .compatible = "qcom,pm660l-wled", .data = (void *)4 },
> > { .compatible = "qcom,pm8150l-wled", .data = (void *)5 },

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog