On 2021-03-01 12:12, John Garry wrote:
Function free_cpu_cached_iovas() is not only called when a CPU is
hotplugged, so remove that part of the code comment.
FWIW I read it as clarifying why this is broken out into a separate function vs. a monolithic "free all cached IOVAs" routine that handles both the per-cpu and global caches
it never said "*only* used..."
As such I'd hesitate to call it incorrect, but it's certainly arguable whether it needs to be stated or not, especially once the hotplug callsite is now obvious in the same file - on which note the function itself also shouldn't need to be public any more, no?
Signed-off-by: John Garry <john.garry@xxxxxxxxxx>.
drivers/iommu/iova.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c
index c78312560425..465b3b0eeeb0 100644
@@ -996,7 +996,7 @@ static void free_iova_rcaches(struct iova_domain *iovad)
- * free all the IOVA ranges cached by a cpu (used when cpu is unplugged)
+ * free all the IOVA ranges cached by a cpu
void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad)