Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init
From: Matti Vaittinen
Date: Wed Mar 24 2021 - 01:03:40 EST
Hello Chanwoo, Greg,
Thanks for the review.
On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote:
> Hi,
>
> Need to fix the work as following:
> s/extconn/extcon
>
> And I'd like you to use the more correct patch title like the
> following example:
> "extcon: Use resource-managed function for delayed work"
I think Greg merged this already. How should we handle this?
> @@ -112,7 +113,9 @@ static int gpio_extcon_probe(struct
> > platform_device *pdev)
> > if (ret < 0)
> > return ret;
> >
> > - INIT_DELAYED_WORK(&data->work, gpio_extcon_work);
> > + ret = devm_delayed_work_autocancel(dev, &data->work,
> > gpio_extcon_work);
> > + if (ret)
> > + return ret;
>
> Need to add the error log as following:
> if (ret) {
> dev_err(dev, "Failed to initialize delayed_work");
> return ret;
> }
I could send incremental patch to Greg for this but it does not change
the commit message.
Best Regards
Matti Vaittinen