Re: [PATCH V3 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes

[rojay]

On 2021-03-23 15:00, Greg KH wrote:
> On Mon, Mar 22, 2021 at 04:34:28PM +0530, Roja Rani Yarubandi wrote:
> > This reverts commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect
> > support to fix earlycon crash")
> >
> > ICC core and platforms drivers supports sync_state feature with
> > commit 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") which
> > ensures that the default ICC BW votes from the bootloader is not
> > removed until all it's consumers are probes.
> >
> > The proxy votes were needed in case other QUP child drivers
> > I2C, SPI probes before UART, they can turn off the QUP-CORE clock
> > which is shared resources for all QUP driver, this causes unclocked
> > access to HW from earlycon.
> >
> > Given above support from ICC there is no longer need to maintain
> > proxy votes on QUP-CORE ICC node from QUP wrapper driver for early
> > console usecase, the default votes won't be removed until real
> > console is probed.
> >
> > Signed-off-by: Roja Rani Yarubandi <rojay@xxxxxxxxxxxxxx>
> > Signed-off-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>
> > Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
>
> Should this have a "Fixes:" tag, and also be cc: stable@xxxxxxxxxxxxxxx
> so that it will be properly backported?
>
> If so, please add and resend.

Okay, will add and resend.

> thanks,
>
> greg k-h