Re: [PATCH 1/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver

From: Pavel Machek
Date: Wed Mar 24 2021 - 06:43:16 EST


Hi!

> > + of_property_read_string(node, "default-state", &state);
> > + if (!strcmp(state, "on"))
> > + multi_gpio_led_set(&priv->cdev, LED_FULL);
> > + else
> > + multi_gpio_led_set(&priv->cdev, LED_OFF);
>
> Again LED_FULL and LED_OFF...
> What about default-state = "keep" ?

Let's not support default-state unless you need it.

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature