Re: [PATCH 1/1] block: fix potential infinite loop in the negative branch in __submit_bio_noacct_mq()

From: Christoph Hellwig
Date: Wed Mar 24 2021 - 07:19:41 EST


On Tue, Mar 23, 2021 at 02:48:36PM +0300, Sergei Shtepa wrote:
> When the blk_crypto_bio_prep() function returns false, the processing
> of the bio request must end. Repeated access to blk_crypto_bio_prep()
> for this same bio may lead to access to already released data, since in
> this case the bio_endio() function was already called for bio.
>
> The changes allow to leave the processing of the failed bio and
> go to the next one from the bio_list.
>
> The error can only occur when using inline encryption on
> request-based blk-mq devices and something went wrong in the
> __blk_crypto_bio_prep().

A continue in a do { } while statement evaluates the while condition,
so your patch is a no-op.