Re: [PATCH v3 1/2] perf stat: Align CSV output for summary mode

From: Arnaldo Carvalho de Melo
Date: Wed Mar 24 2021 - 09:23:29 EST


Em Mon, Mar 22, 2021 at 10:15:48PM +0100, Jiri Olsa escreveu:
> On Fri, Mar 19, 2021 at 03:01:55PM +0800, Jin Yao wrote:
>
> SNIP
>
> > 102107,,branch-misses,8012781751,100.00,4.15,of all branches
> >
> > This option can be enabled in perf config by setting the variable
> > 'stat.no-cvs-summary'.
> >
> > # perf config stat.no-cvs-summary=true
> >
> > # perf config -l
> > stat.no-cvs-summary=true
> >
> > # perf stat -x, -I1000 --interval-count 1 --summary
> > 1.001330198,8013.28,msec,cpu-clock,8013279201,100.00,8.013,CPUs utilized
> > 1.001330198,205,,context-switches,8013308394,100.00,25.583,/sec
> > 1.001330198,10,,cpu-migrations,8013324681,100.00,1.248,/sec
> > 1.001330198,0,,page-faults,8013340926,100.00,0.000,/sec
> > 1.001330198,8027742,,cycles,8013344503,100.00,0.001,GHz
> > 1.001330198,2871717,,instructions,8013356501,100.00,0.36,insn per cycle
> > 1.001330198,553564,,branches,8013366204,100.00,69.081,K/sec
> > 1.001330198,54021,,branch-misses,8013375952,100.00,9.76,of all branches
> > 8013.28,msec,cpu-clock,8013279201,100.00,7.985,CPUs utilized
> > 205,,context-switches,8013308394,100.00,25.583,/sec
> > 10,,cpu-migrations,8013324681,100.00,1.248,/sec
> > 0,,page-faults,8013340926,100.00,0.000,/sec
> > 8027742,,cycles,8013344503,100.00,0.001,GHz
> > 2871717,,instructions,8013356501,100.00,0.36,insn per cycle
> > 553564,,branches,8013366204,100.00,69.081,K/sec
> > 54021,,branch-misses,8013375952,100.00,9.76,of all branches
> >
> > Signed-off-by: Jin Yao <yao.jin@xxxxxxxxxxxxxxx>
>
> LGTM, for patchset:
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

After doing the s/cvs/csv/ changes, applied.

- Arnaldo