Re: [PATCH 4/4] dt-bindings: usb: Add chg-psy-name property Maxim 33359 binding

From: Rob Herring
Date: Wed Mar 24 2021 - 10:51:42 EST


On Thu, Mar 11, 2021 at 02:03:13AM -0800, Badhri Jagan Sridharan wrote:
> chg-psy-name is an optional string property used to indicate the
> power supply object for which the current/voltage_max limits have
> to be set.
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> index 93a19eda610b..3a278969109e 100644
> --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> @@ -28,6 +28,11 @@ properties:
> description:
> Properties for usb c connector.
>
> + chg-psy-name:
> + description: Power supply whose current/voltage_max values to be
> + configured.
> + $ref: /schemas/types.yaml#definitions/string

If you want a non-vendor specific property, this needs to be documented
in a common binding. I think this needs a better explaination and
examples of multiple chargers.

Rob