Re: [PATCH v6] mm: cma: support sysfs

From: Minchan Kim
Date: Wed Mar 24 2021 - 11:13:14 EST


On Wed, Mar 24, 2021 at 03:33:07PM +0300, Dmitry Osipenko wrote:
> 24.03.2021 04:05, Minchan Kim пишет:
> > +static struct kobject *cma_kobj_root;
>
> This should be a local variable.

Sure.

>
> > +static struct kobj_type cma_ktype = {
> > + .release = cma_kobj_release,
> > + .sysfs_ops = &kobj_sysfs_ops,
> > + .default_groups = cma_groups
>
> I'd add a comma to the end, for consistency.

Yub.