Re: [PATCH] [v2] audit: avoid -Wempty-body warning

From: Paul Moore
Date: Wed Mar 24 2021 - 12:15:05 EST


On Mon, Mar 22, 2021 at 12:28 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> gcc warns about an empty statement when audit_remove_mark is defined to
> nothing:
>
> kernel/auditfilter.c: In function 'audit_data_to_entry':
> kernel/auditfilter.c:609:51: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 609 | audit_remove_mark(entry->rule.exe); /* that's the template one */
> | ^
>
> Change the macros to use the usual "do { } while (0)" instead, and change a
> few more that were (void)0, for consistency.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> v2: convert two more macros
> ---
> kernel/audit.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Merged into audit/next, thanks.

--
paul moore
www.paul-moore.com