Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

From: Stephen Boyd
Date: Wed Mar 24 2021 - 12:29:28 EST


Quoting Stephen Boyd (2021-03-24 08:57:33)
> Quoting sbhanu@xxxxxxxxxxxxxx (2021-03-24 08:23:55)
> > On 2021-03-23 12:31, Stephen Boyd wrote:
> > > Quoting Shaik Sajida Bhanu (2021-03-20 11:17:00)
> > >> +
> > >> + bus-width = <8>;
> > >> + non-removable;
> > >> + supports-cqe;
> > >> + no-sd;
> > >> + no-sdio;
> > >> +
> > >> + max-frequency = <192000000>;
> > >
> > > Is this necessary?
> > yes, to avoid lower speed modes running with high clock rates.
>
> Is it part of the DT binding? I don't see any mention of it.

Nevermind, found it in mmc-controller.yaml. But I think this is to work
around some problem with the clk driver picking lower speeds than
requested? That has been fixed on the clk driver side (see commit like
148ddaa89d4a "clk: qcom: gcc-sc7180: Use floor ops for the correct sdcc1
clk") so ideally this property can be omitted.