Re: [PATCH] ARM: xen/mm.c: A mundane typo fix

[Stefano Stabellini]

On Wed, 24 Mar 2021, Randy Dunlap wrote:
> On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
> >> s/acrros/across/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > 
> > 
> 
> Hi,
> It seems to me like some of those "page" should be "pages".

Yes, good point actually


> >> ---
> >>  arch/arm/xen/mm.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> >> index 467fa225c3d0..be7c942c74bf 100644
> >> --- a/arch/arm/xen/mm.c
> >> +++ b/arch/arm/xen/mm.c
> >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
> >>  	 *	- The Linux page refers to foreign memory
> >>  	 *	- The device doesn't support coherent DMA request
> >>  	 *
> >> -	 * The Linux page may be spanned acrros multiple Xen page, although>> +	 * The Linux page may be spanned across multiple Xen page, although
> 
> 	                                                     pages,
> 
> >>  	 * it's not possible to have a mix of local and foreign Xen page.
> 
> 	                                                            pages.

yes to both


> >>  	 * Furthermore, range_straddles_page_boundary is already checking
> >>  	 * if buffer is physically contiguous in the host RAM.
> >> --
> 
> 
> -- 
> ~Randy
>