Re: [PATCH] firmware: stratix10-svc: build only on 64-bit ARM

[Richard Gong]

On 3/21/21 1:46 PM, Krzysztof Kozlowski wrote:
> The Stratix10 service layer and RCU drivers are useful only on
> Stratix10, so on ARMv8.  Compile testing the RCU driver on 32-bit ARM
> fails:
>
>    drivers/firmware/stratix10-rsu.c: In function 'rsu_status_callback':
>    include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_179'
>      declared with attribute error: FIELD_GET: type of reg too small for mask
>      _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>    ...
>    drivers/firmware/stratix10-rsu.c:96:26: note: in expansion of macro 'FIELD_GET'
>      priv->status.version = FIELD_GET(RSU_VERSION_MASK,
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> ---
>
> Fix for commit in:
> https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git
> ---
>   drivers/firmware/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 6a4e882e448d..08bd4d01fb04 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -206,7 +206,7 @@ config FW_CFG_SYSFS_CMDLINE
>   
>   config INTEL_STRATIX10_SERVICE
>   	tristate "Intel Stratix10 Service Layer"
> -	depends on ARCH_INTEL_SOCFPGA && HAVE_ARM_SMCCC
> +	depends on ARCH_INTEL_SOCFPGA && ARM64 && HAVE_ARM_SMCCC
>   	default n
>   	help
>   	  Intel Stratix10 service layer runs at privileged exception level,
Acked-by: Richard Gong <richard.gong@xxxxxxxxxxxxxxx>

Regards,
Richard